We use a version of Git Flow for branching (since everyone is talking about branching strategies here). But technically, you asked specifically about code review process. Every ticket is it’s own branch against the development branch, and when complete is merged by PR into the development branch. We’re a small team, so our current process is:

1. Merges to the development branch require one approval
2. Merges to the main branch for a release require two approvals
3. If the changes are only code, any developer can review and approve
4. If there are “significant” SQL changes a DBA approval is required.
   • “significant” means a new entity in the DB, or…
   • an inline/Dapper query with a join

As we grow we’ll probably have to silo more and require specific people’s approval for specific areas.

A lot of what we do is “cultural”, like encouraging readability, avoiding hard-coded values, and fixing issues near the altered code even when not related to the original ticket. The key is to be constructive. The goal is better code, not competition. So far we have the right people for that to work.

Modding as we know it today really started with Civ (Civ II, to be precise). There were several sites sharing different mods back then. I had one of the most popular ones for a while, to the point where MicroProse asked to post a link on the official site. The mods were ZIP files with instructions, and nobody had come up with a name for them. I started referring to them as “modpacks”, and that stuck. Eventually that was shortened to just “mods”. True story!

(FYI you can see here where MicroProse put links to other websites. Mine was listed in 1997, where the wayback machine doesn’t have entries.)